Skip to content

fix FILEPKG so that MAKEFILE(NEW) never references the 'previous version' and recompiles the whole file#1523

Draft
masinter wants to merge 2 commits intomasterfrom
makefile-new-fix
Draft

fix FILEPKG so that MAKEFILE(NEW) never references the 'previous version' and recompiles the whole file#1523
masinter wants to merge 2 commits intomasterfrom
makefile-new-fix

Conversation

@masinter
Copy link
Copy Markdown
Member

No description provided.

…from previous version if you do MAKEFILE(something NEW).
@masinter
Copy link
Copy Markdown
Member Author

I updated this PR to fix MAKEFILE rather than make a new MAKEFILE-NEW function.
I also changed the default for compiling -- which was set to only recompile those functions that were EXPRP; this was done for speed but it's not a good idea for many situations.

@masinter masinter requested a review from rmkaplan April 18, 2024 21:58
@masinter masinter marked this pull request as draft April 19, 2024 22:34
@masinter masinter closed this Jun 24, 2024
@masinter
Copy link
Copy Markdown
Member Author

closed by mistake

@masinter masinter reopened this Jun 24, 2024
@MattHeffron
Copy link
Copy Markdown
Member

I thought that this actually had already been done...

@masinter
Copy link
Copy Markdown
Member Author

I made this PR a draft in order to combine the logic for the MAKEFILE(flie NEW) and the "normal" MAKEFILE rather than hacking another pass.

The problem is that there are a number of loose ends in the current design/implementation.
The current design is that it will copy the bytes of previous definitions without re-pretty printing. But that misses some cases where things have changed but the communication from MARKASCHANGED and teh file package is faulty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants